Updated the max length of gender field to 35 in patient model #2720

DraKen0009 · 2025-01-07T18:30:47Z

Proposed Changes

Updated the max lenght of gender field to 35 in patient model

Associated Issue

Merge Checklist

Tests added/fixed
Update docs in /docs
Linting Complete
Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

Bug Fixes
- Updated patient gender field to support a broader range of gender identities by increasing maximum length from 10 to 35 characters.

coderabbitai · 2025-01-07T18:30:55Z

📝 Walkthrough

Walkthrough

A migration script has been introduced to modify the gender field in the Patient model, expanding its maximum length from 10 to 35 characters. This change allows for more comprehensive gender representation in the patient records. The modification is implemented through both a model update and a corresponding migration file, ensuring database schema consistency.

Changes

File	Change Summary
`care/emr/models/patient.py`	Increased `gender` field max length from 10 to 35 characters
`care/emr/migrations/0002_alter_patient_gender.py`	Created migration to alter `gender` field configuration

Poem

🏥 Gender's boundaries softly expand
Thirty-five characters now at hand
A migration's gentle, precise embrace
Inclusivity finds its rightful space
Coding compassion, line by line 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🔭 Outside diff range comments (1)

care/emr/models/patient.py (1)
Line range hint 39-39: Fix the CharField definition for blood_group.

Oh, looks like someone forgot that CharField needs a max_length parameter. This will raise a Django system check error.

Apply this fix:
-    blood_group = models.CharField()
+    blood_group = models.CharField(max_length=5, default="")

🧹 Nitpick comments (2)

care/emr/models/patient.py (1)
15-15: Consider adding validation for consistent data entry.

While increasing the max_length is... nice, we might want to consider adding some basic validation or choices to ensure data consistency. You know, just to avoid having 35 different ways to spell the same gender.

Consider adding choices like this:
-    gender = models.CharField(max_length=35, default="")
+    GENDER_CHOICES = [
+        ("M", "Male"),
+        ("F", "Female"),
+        ("O", "Other"),
+        ("N", "Prefer not to say"),
+    ]
+    gender = models.CharField(
+        max_length=35,
+        default="",
+        choices=GENDER_CHOICES,
+        blank=True,
+    )
care/emr/migrations/0002_alter_patient_gender.py (1)
9-17: Maintain quote style consistency.

I see we're mixing single and double quotes here. The static analysis tool is gently suggesting we stick to double quotes, as per the project's style guide.

Here's a quick fix:
-        ('emr', '0001_initial'),
+        ("emr", "0001_initial"),
-            model_name='patient',
-            name='gender',
-            field=models.CharField(default='', max_length=35),
+            model_name="patient",
+            name="gender",
+            field=models.CharField(default="", max_length=35),
🧰 Tools

🪛 Ruff (0.8.2)

9-9: Single quotes found but double quotes preferred

Replace single quotes with double quotes

(Q000)

9-9: Single quotes found but double quotes preferred

Replace single quotes with double quotes

(Q000)

14-14: Single quotes found but double quotes preferred

Replace single quotes with double quotes

(Q000)

15-15: Single quotes found but double quotes preferred

Replace single quotes with double quotes

(Q000)

16-16: Single quotes found but double quotes preferred

Replace single quotes with double quotes

(Q000)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b80ab51 and ceb876e.

📒 Files selected for processing (2)

care/emr/migrations/0002_alter_patient_gender.py (1 hunks)
care/emr/models/patient.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.8.2)

care/emr/migrations/0002_alter_patient_gender.py

9-9: Single quotes found but double quotes preferred