fixed dockerfile for local plugin installation #2622
Conversation
📝 WalkthroughWalkthroughThe changes in the Dockerfile primarily focus on the installation and configuration of the Typst application and Python dependencies. Modifications include the removal of specific Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docker/dev.Dockerfile (2)
Line range hint
19-33: Oh, I see what you did with the Typst installation... but maybe we could make it better?While the architecture detection is... creative, we might want to consider a few tiny improvements for security and efficiency:
RUN ARCH=$(dpkg --print-architecture) && \ + TYPST_SHA256="e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" && \ if [ "$ARCH" = "amd64" ]; then \ TYPST_ARCH="x86_64-unknown-linux-musl"; \ elif [ "$ARCH" = "arm64" ]; then \ TYPST_ARCH="aarch64-unknown-linux-musl"; \ else \ echo "Unsupported architecture: $ARCH"; \ exit 1; \ fi && \ wget -qO typst.tar.xz https://github.com/typst/typst/releases/download/v${TYPST_VERSION}/typst-${TYPST_ARCH}.tar.xz && \ + echo "${TYPST_SHA256} typst.tar.xz" | sha256sum -c - && \ tar -xf typst.tar.xz && \ mv typst-${TYPST_ARCH}/typst /usr/local/bin/typst && \ chmod +x /usr/local/bin/typst && \ rm -rf typst.tar.xz typst-${TYPST_ARCH}
Line range hint
1-43: The Dockerfile structure is... interesting. Here are some suggestions that might help.While the changes address the plugin installation issue, we could make the Dockerfile even better with a few adjustments:
- Add a
.dockerignorefile to prevent copying unnecessary files:.git __pycache__ *.pyc .env
- Consider using
COPY --chown=python:pythonfor better security:-COPY . $APP_HOME/ +COPY --chown=python:python . $APP_HOME/
- Consider adding a non-root user:
+RUN useradd -m python +USER pythonThese changes would make the Dockerfile just a tiny bit more production-ready... if you're interested in that sort of thing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
docker/dev.Dockerfile(1 hunks)
🔇 Additional comments (1)
docker/dev.Dockerfile (1)
42-42: Just a tiny verification needed for the plugin installation...
The installation timing looks better now, but let's make absolutely sure everything is in place:
✅ Verification successful
Well, would you look at that... everything seems perfectly fine
The installation script is actually quite well-structured. It uses a proper plugin management system that:
- Installs plugins via pip (using subprocess, as one should)
- Supports both predefined plugins and additional ones from environment variables
- Has proper validation and error handling
The cache mount for pip in the Dockerfile will work seamlessly with this setup. I suppose I could almost say it's... elegant.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify install_plugins.py exists and has necessary imports
if [ -f "install_plugins.py" ]; then
echo "Checking install_plugins.py dependencies..."
rg -l "^import|^from.*import" "install_plugins.py"
else
echo "Warning: install_plugins.py not found in repository root"
fi
Length of output: 198
Script:
#!/bin/bash
# Let's see what's actually in that install_plugins.py, shall we?
echo "=== Content of install_plugins.py ==="
cat install_plugins.py
echo -e "\n=== Checking if pip is imported ==="
rg "import pip|from pip" install_plugins.py
echo -e "\n=== Looking for subprocess or system calls ==="
rg "subprocess|os\.system|pip install" install_plugins.py
Length of output: 462
Script:
#!/bin/bash
# Oh, let's see what this mysterious plug_config manager is about...
echo "=== Looking for plug_config.py ==="
fd plug_config.py
echo -e "\n=== Content of plug_config.py (if found) ==="
fd plug_config.py -x cat {}
echo -e "\n=== Any other files mentioning plug_config? ==="
rg -l "plug_config" --type py
Length of output: 2648
Script:
#!/bin/bash
# Let's see what this PlugManager actually does...
echo "=== Looking for plugs/manager.py ==="
fd manager.py -t f
echo -e "\n=== Content of any manager.py files ==="
fd manager.py -t f -x cat {}
echo -e "\n=== And what about this Plug class? ==="
fd plug.py -t f -x cat {}
Length of output: 2921
Proposed Changes
Local plugins weren't getting installed after the recent changes in dockerfile.
Issue - local plugin folder was copied after the running the install command
Tested locally
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins
Summary by CodeRabbit