Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test cases for asset bed #2532

Merged

Conversation

DraKen0009
Copy link
Contributor

Proposed Changes

  • Added test cases for asset bed module
  • Adding more test for bed create module
  • Updated PermissionError with PermissionDenied for better handling of permission errors

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner October 13, 2024 00:46
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.27%. Comparing base (39c7aa4) to head (53c6e20).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
care/facility/api/serializers/asset.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2532      +/-   ##
===========================================
+ Coverage    69.19%   69.27%   +0.08%     
===========================================
  Files          211      211              
  Lines        11940    11943       +3     
  Branches      1208     1208              
===========================================
+ Hits          8262     8274      +12     
+ Misses        3302     3297       -5     
+ Partials       376      372       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either merge or refactor the tests with this file? Recently few tests for asset bed has been added.

https://github.com/ohcnetwork/care/blob/develop/care/facility/tests/test_asset_bed_api.py

@rithviknishad rithviknishad requested a review from sainak October 22, 2024 13:57
@vigneshhari vigneshhari merged commit 8f352e8 into ohcnetwork:develop Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adds test for various endpoints in the assetbed module
4 participants