disable aspect ratio validation for images

care/utils/models/validators.py

@@ -42,12 +42,12 @@
         errors: Iterable[jsonschema.ValidationError],
         container: list[ValidationError],
     ):
         for error in errors:
             if error.context:
                 return self._extract_errors(error.context, container)
 
             message = str(error).replace("\n\n", ": ").replace("\n", "")
             container.append(ValidationError(message))
 
 
 @deconstructible
@@ -88,23 +88,23 @@
     landline_number_regex = r"^\+91[2-9]\d{7,9}$"
     support_number_regex = r"^(1800|1860)\d{6,7}$"
 
     regex_map = {
         "indian_mobile": indian_mobile_number_regex,
         "international_mobile": international_mobile_number_regex,
         "mobile": rf"{indian_mobile_number_regex}|{international_mobile_number_regex}",
         "landline": landline_number_regex,
         "support": support_number_regex,
     }
 
     def __init__(self, types: Iterable[str], *args, **kwargs):
         if not isinstance(types, Iterable) or isinstance(types, str) or len(types) == 0:
             raise ValueError("The `types` argument must be a non-empty iterable.")
 
         self.types = types
         self.message = f"Invalid phone number. Must be one of the following types: {', '.join(self.types)}. Received: %(value)s"
         self.code = "invalid_phone_number"
 
         self.regex = r"|".join([self.regex_map[type] for type in self.types])
         super().__init__(*args, **kwargs)
 
     def __eq__(self, other):
@@ -127,7 +127,7 @@
         min_amount: int | float,
         max_amount: int | float,
         units: Iterable[str],
         allow_floats: bool = True,
         precision: int = 2,
     ):
         self.min_amount = min_amount
@@ -140,7 +140,7 @@
             isinstance(min_amount, float) or isinstance(max_amount, float)
         ):
             raise ValueError(
                 "If floats are not allowed, min_amount and max_amount must be integers"
             )
 
     def __call__(self, value: str):
@@ -148,20 +148,20 @@
             amount, unit = value.split(" ", maxsplit=1)
             if unit not in self.allowed_units:
                 raise ValidationError(
                     f"Unit must be one of {', '.join(self.allowed_units)}"
                 )
 
             amount_number: int | float = float(amount)
             if amount_number.is_integer():
                 amount_number = int(amount_number)
             elif not self.allow_floats:
                 raise ValidationError("Input amount must be an integer")
             elif len(str(amount_number).split(".")[1]) > self.precision:
                 raise ValidationError("Input amount must have at most 4 decimal places")
 
             if len(amount) != len(str(amount_number)):
                 raise ValidationError(
                     f"Input amount must be a valid number without leading{' or trailing ' if self.allow_floats else ' '}zeroes"
                 )
 
             if self.min_amount > amount_number or amount_number > self.max_amount:
@@ -248,6 +248,9 @@
             self.aspect_ratio_str = ", ".join(
                 f"{ratio.numerator}:{ratio.denominator}" for ratio in self.aspect_ratio
             )
+        else:
+            self.aspect_ratio = None
+            self.aspect_ratio_str = None
 
     def __call__(self, value: UploadedFile) -> None:
         with Image.open(value.file) as image:
@@ -326,7 +329,6 @@
     min_height=400,
     max_width=1024,
     max_height=1024,
-    aspect_ratio=[1 / 1],
     min_size=1024,  # 1 KB
     max_size=1024 * 1024 * 2,  # 2 MB
 )

care/utils/tests/test_image_validator.py

@@ -60,15 +60,3 @@ def test_invalid_image_too_large(self):
                 "Image size is greater than the maximum allowed size of 2 MB.",
             ],
         )
-
-    def test_invalid_image_aspect_ratio(self):
-        image = Image.new("RGB", (400, 800))
-        file = io.BytesIO()
-        image.save(file, format="JPEG")
-        test_file = UploadedFile(file, "test.jpg", "image/jpeg", 2048)
-        with self.assertRaises(ValidationError) as cm:
-            self.cover_image_validator(test_file)
-        self.assertEqual(
-            cm.exception.messages,
-            ["Image aspect ratio must be one of the following: 1:1."],
-        )