Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable default jwks for production deployments #2414

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 30, 2024

Proposed Changes

  • if no key is speciied django will generate a new key, this causes issues with deployments with multiple instances of the backend
  • in case of local environments instead of generating a new key on every startup, get/set the key from the file if not present

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@sainak sainak requested a review from a team as a code owner August 30, 2024 11:15
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (00ce264) to head (d7177fa).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/jwks/generate_jwk.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2414      +/-   ##
===========================================
- Coverage    65.42%   65.38%   -0.05%     
===========================================
  Files          242      242              
  Lines        13965    13976      +11     
  Branches      1935     1937       +2     
===========================================
+ Hits          9137     9138       +1     
- Misses        4445     4455      +10     
  Partials       383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 12afd7a into develop Sep 22, 2024
4 of 5 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/jwks-defaults branch September 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants