Explicity mention Public Read ACL for Facility Image S3 Uploads #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2344 +/- ##
========================================
Coverage 63.71% 63.71%
========================================
Files 238 238
Lines 13376 13376
Branches 1906 1906
========================================
Hits 8522 8522
Misses 4504 4504
Partials 350 350 ☔ View full report in Codecov by Sentry. |
shivankacker
approved these changes
Aug 8, 2024
rithviknishad
approved these changes
Aug 8, 2024
|
@amjithtitus09 Are there anymore changes that is to be made? If not you can mark the PR as ready for review instead of keeping it as draft. |
66c5d4e to
8b19335
Compare
|
@rithviknishad Marked as Ready for review |
|
Tested out in digitalocean. Solves issue #2335. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Setting ACL='public-read' specifies that the uploaded object should be publicly accessible regardless of whether AWS S3 or another S3-compatible provider is being used
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins