Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only log the error message in uptime monitor tasks #2181

Merged
merged 1 commit into from
May 20, 2024
Merged

Only log the error message in uptime monitor tasks #2181

merged 1 commit into from
May 20, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented May 20, 2024

Proposed Changes

  • printing the whole exc_info was creating a lot of unnessary logs, instead we could just print the error message

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner May 20, 2024 16:58
@gigincg gigincg merged commit 5c715f8 into develop May 20, 2024
9 checks passed
@gigincg gigincg deleted the sainak/fix/asset-monitor-log branch May 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainak @gigincg