-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the Bed List of Already occupied Beds (back-end change) #2116
Disable the Bed List of Already occupied Beds (back-end change) #2116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there is no need to make the filter specific to hl7 monitor right? We can make a filter not_occupied_by_asset_type
which accepts the asset type to exclude.
This way it'd work for excluding ONVIF cameras or ventilators too if needed in the future.
yes makes sense and is also scalable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests needed
@rithviknishad i have added a test |
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2116 +/- ##
===========================================
+ Coverage 62.20% 62.71% +0.51%
===========================================
Files 221 237 +16
Lines 12204 13035 +831
Branches 1742 1853 +111
===========================================
+ Hits 7591 8175 +584
- Misses 4305 4522 +217
- Partials 308 338 +30 ☔ View full report in Codecov by Sentry. |
LGTM @rithviknishad @sainak can you fix the lint issue |
Proposed Changes
Associated Issue
Fixes link
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins