Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for beds endpoints #2104

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

DraKen0009
Copy link
Contributor

@DraKen0009 DraKen0009 commented Apr 20, 2024

Proposed Changes

  • Created Testcases for Bed Enpoint

Associated Issue

fixes #2103

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner April 20, 2024 17:01
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor improvements

care/facility/tests/test_bed_api.py Show resolved Hide resolved
care/facility/tests/test_bed_api.py Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nitpicks to follow consistent patterns

care/facility/tests/test_bed_api.py Outdated Show resolved Hide resolved
care/facility/tests/test_bed_api.py Outdated Show resolved Hide resolved
care/facility/tests/test_bed_api.py Outdated Show resolved Hide resolved
@gigincg
Copy link
Member

gigincg commented May 14, 2024

@DraKen0009 Can you make the changes?

@DraKen0009
Copy link
Contributor Author

Yep. I'll update the PR by tonight or tomorrow afternoon.

@DraKen0009
Copy link
Contributor Author

@rithviknishad updated the PR. Can you please run the workflows once

care/facility/tests/test_bed_api.py Outdated Show resolved Hide resolved
care/facility/tests/test_bed_api.py Show resolved Hide resolved
@sainak sainak requested a review from rithviknishad May 20, 2024 15:44
@DraKen0009
Copy link
Contributor Author

@sainak Fixed the conflicts, please check once

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DraKen0009 tests are failing, please check

@DraKen0009
Copy link
Contributor Author

@skks1212 fixed it. Can you please run the workflows again.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to resolve all open conversations

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (7d756d6) to head (b4dbc46).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2104      +/-   ##
===========================================
+ Coverage    63.49%   63.59%   +0.10%     
===========================================
  Files          238      238              
  Lines        13265    13265              
  Branches      1886     1886              
===========================================
+ Hits          8422     8436      +14     
+ Misses        4490     4479      -11     
+ Partials       353      350       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit b30aee6 into ohcnetwork:develop Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test cases for Beds module
7 participants