-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tests for beds endpoints #2104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nitpicks to follow consistent patterns
@DraKen0009 Can you make the changes? |
Yep. I'll update the PR by tonight or tomorrow afternoon. |
@rithviknishad updated the PR. Can you please run the workflows once |
@sainak Fixed the conflicts, please check once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DraKen0009 tests are failing, please check
@skks1212 fixed it. Can you please run the workflows again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure to resolve all open conversations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2104 +/- ##
===========================================
+ Coverage 63.49% 63.59% +0.10%
===========================================
Files 238 238
Lines 13265 13265
Branches 1886 1886
===========================================
+ Hits 8422 8436 +14
+ Misses 4490 4479 -11
+ Partials 353 350 -3 ☔ View full report in Codecov by Sentry. |
Proposed Changes
Associated Issue
fixes #2103
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins