Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add medicine filter to prescriptions #2068

Merged
merged 7 commits into from
May 8, 2024
Merged

Add medicine filter to prescriptions #2068

merged 7 commits into from
May 8, 2024

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Apr 9, 2024 •
edited
Loading

Partially fixes #7354

Proposed Changes

  • Add Medicine as a filter for the Prescription Consultation Viewset

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner April 9, 2024 10:01
@Pranshu1902 Pranshu1902 changed the title Log Change of Prescriptions and send it through API Log Change of Prescriptions based on medicine Apr 9, 2024
rithviknishad
rithviknishad requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests

care/facility/api/viewsets/prescription.py Outdated Show resolved Hide resolved
@Pranshu1902 Pranshu1902 mentioned this pull request Apr 11, 2024
Merged
6 tasks
@sainak sainak changed the title Log Change of Prescriptions based on medicine Add medicine filter to prescriptions Apr 30, 2024
@nihal467
Copy link
Member

nihal467 commented May 8, 2024 •
edited
Loading

related Frontend is still having bugs, @Pranshu1902 can you make the related change

@vigneshhari can you only review this PR, don't merge it,

@rithviknishad
Copy link
Member

@nihal467 This PR can be reviewed and merged even if front-end changes maybe required.

cc: @sainak

@nihal467
Copy link
Member

nihal467 commented May 8, 2024 •
edited
Loading

@nihal467 This PR can be reviewed and merged even if front-end changes maybe required.

cc: @sainak

@vigneshhari cool ! can you review and merge it :)

@vigneshhari vigneshhari merged commit 0bf4d1d into ohcnetwork:develop May 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@sainak sainak sainak approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prescription- Log of change
5 participants
@Pranshu1902 @nihal467 @rithviknishad @vigneshhari @sainak