Occupation dropdown backend #2055
Conversation
|
@rithviknishad I changed this in my windows machine just to run the command and pushed it by mistake I changed it back and i guess its fine now added migration also |
| (8, "Business_related"), | ||
| (9, "ENGINEER"), | ||
| (10, "TEACHER"), | ||
| (11, "Other_Professions"), |
There was a problem hiding this comment.
Do we need both "Other_Pressions" and "OTHERS"
There was a problem hiding this comment.
@rithviknishad maybe we can consider other skilled professions that was mentioned in the dropdown suggstions list so i added
There was a problem hiding this comment.
@rithviknishad in the frontend Other professional occupations were mentioned and professional occupation is a separate type and the corresponding value is OTHER_PROFESSIONS not to be confused with OTHERS and its not the same. This is needed.
There was a problem hiding this comment.
Rename it in backend too. It could lead to confusions.
Also change to use uppercase for all
|
@rithviknishad I capitalized the names and also capitalized in the frontend |
|
@hrit2773 delete the migrations and rerun makemigrations |
|
@sainak @rithviknishad plz review this pr |
care/facility/models/patient.py
Outdated
| OTHERS = 6 | ||
| HEALTHCARE_PRACTITIONER = 6 | ||
| PARADEMICS = 7 | ||
| BUSINESS_RELATED = 8 | ||
| ENGINEER = 9 | ||
| TEACHER = 10 | ||
| OTHER_PROFESSIONAL_OCCUPATIONS = 11 | ||
| OFFICE_ADMINISTRATIVE = 12 | ||
| CHEF = 13 | ||
| PROTECTIVE_SERVICE = 14 | ||
| HOSPITALITY = 15 | ||
| CUSTODIAL = 16 | ||
| CUSTOMER_SERVICE = 17 | ||
| SALES_SUPERVISOR = 18 | ||
| RETAIL_SALES_WORKER = 19 | ||
| INSURANCE_SALES_AGENT = 20 | ||
| SALES_REPRESENTATIVE = 21 | ||
| REAL_ESTATE = 22 | ||
| CONSTRUCTION_EXTRACTION = 23 | ||
| AGRI_NATURAL = 24 | ||
| PRODUCTION_OCCUPATION = 25 | ||
| PILOT_FLIGHT = 26 | ||
| VEHICLE_DRIVER = 27 | ||
| MILITARY = 28 | ||
| HOMEMAKER = 29 | ||
| OTHERS = 30 | ||
| UNKNOWN = 31 | ||
| NOT_APPLICABLE = 32 |
There was a problem hiding this comment.
OTHERS was previously 6 and is now 30. And 6 is now Healthcare Practitioner. This would mean, all previously entered patients with occupation as "Other" before this PR would become a Healthcare Practitioner once this is merged.
|
@rithviknishad yes you are right OTHERS would be misread as HEALTHCARE PRACTIOTIONER so changed it. And i made changes in the frontend also |
|
@hrit2773 there is migration issue, fix it |
|
@nihal467 but it's working fine when I'm running it the occupation is being added and displayed properly. Should I re-run the migrations? |
|
@nihal467 can you check it now maybe there were some conflicting migrations before |
Proposed Changes
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins