Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition that caused service to be unhealthy and merge migrations #2048

Merged
merged 1 commit into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions care/facility/migrations/0425_merge_20240403_2055.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Generated by Django 4.2.10 on 2024-04-03 15:25

from django.db import migrations


class Migration(migrations.Migration):
dependencies = [
("facility", "0422_alter_facilityinventorylog_quantity_and_more"),
(
"facility",
"0424_remove_patientregistration_age_and_add_patientregistration_death_datetime",
),
]

operations = []
10 changes: 8 additions & 2 deletions docker-compose.local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,21 @@ services:
ports:
- "9000:9000"
- "9876:9876" #debugpy
restart: unless-stopped
depends_on:
- db
- redis
db:
condition: service_started
redis:
condition: service_started
celery:
condition: service_healthy

celery:
image: care_local
env_file:
- ./docker/.local.env
entrypoint: [ "bash", "scripts/celery-dev.sh" ]
restart: unless-stopped
depends_on:
- db
- redis
Expand Down
19 changes: 15 additions & 4 deletions docker-compose.pre-built.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@ services:
env_file:
- ./docker/.prebuilt.env
entrypoint: [ "bash", "start-ecs.sh" ]
restart: unless-stopped
depends_on:
- db
- redis
db:
condition: service_started
redis:
condition: service_started
celery-beat:
condition: service_healthy
ports:
- "9000:9000"

Expand All @@ -17,15 +22,21 @@ services:
env_file:
- ./docker/.prebuilt.env
entrypoint: [ "bash", "celery_worker-ecs.sh" ]
restart: unless-stopped
depends_on:
- db
- redis
db:
condition: service_started
redis:
condition: service_started
celery-beat:
condition: service_healthy

celery-beat:
image: "ghcr.io/coronasafe/care:latest"
env_file:
- ./docker/.prebuilt.env
entrypoint: [ "bash", "celery_beat-ecs.sh" ]
restart: unless-stopped
depends_on:
- db
- redis
9 changes: 5 additions & 4 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,21 @@ networks:
services:
db:
image: postgres:alpine
restart: always
restart: unless-stopped
env_file:
- ./docker/.prebuilt.env
volumes:
- postgres-data:/var/lib/postgresql/data

redis:
image: redis/redis-stack-server:6.2.6-v10
restart: always
restart: unless-stopped
volumes:
- redis-data:/data

localstack:
image: localstack/localstack:latest
restart: unless-stopped
environment:
- AWS_DEFAULT_REGION=ap-south-1
- EDGE_PORT=4566
Expand All @@ -34,8 +35,8 @@ services:
- "4566:4566"

fidelius:
image: khavinshankar/fidelius:v1.0
restart: always
image: khavinshankar/fidelius:latest
restart: unless-stopped

volumes:
postgres-data:
Expand Down
2 changes: 1 addition & 1 deletion docker/dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ HEALTHCHECK \
--interval=10s \
--timeout=5s \
--start-period=10s \
--retries=12 \
--retries=24 \
CMD ["/app/scripts/healthcheck.sh"]

WORKDIR /app
2 changes: 1 addition & 1 deletion scripts/celery-dev.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

printf "celery" >> /tmp/container-role
printf "celery" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/celery_beat-ecs.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
printf "celery-beat" >> /tmp/container-role
printf "celery-beat" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/celery_beat.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
printf "celery-beat" >> /tmp/container-role
printf "celery-beat" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/celery_worker-ecs.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
printf "celery-worker" >> /tmp/container-role
printf "celery-worker" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/celery_worker.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
printf "celery-worker" >> /tmp/container-role
printf "celery-worker" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/start-dev.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -euo pipefail

printf "api" >> /tmp/container-role
printf "api" > /tmp/container-role

cd /app

Expand Down
2 changes: 1 addition & 1 deletion scripts/start-ecs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -o errexit
set -o pipefail
set -o nounset

printf "api" >> /tmp/container-role
printf "api" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -o errexit
set -o pipefail
set -o nounset

printf "api" >> /tmp/container-role
printf "api" > /tmp/container-role

if [ -z "${DATABASE_URL}" ]; then
export DATABASE_URL="postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}"
Expand Down
Loading