Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes discharged patients CSV export #2009

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 25, 2024

Warning

Base branch is staging

Proposed Changes

  • Fixed queryset filter logic to allow for CSV exports, resulting in an empty list for discharged patients.

Associated Issue

Screenshots

Discharged Patients List and Export

image image

Live Patients List and Export

image image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad requested review from vigneshhari and sainak and removed request for vigneshhari March 25, 2024 08:09
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.36%. Comparing base (8358849) to head (2f5de5d).

Files Patch % Lines
care/facility/api/viewsets/patient.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2009      +/-   ##
===========================================
- Coverage    62.37%   62.36%   -0.01%     
===========================================
  Files          221      221              
  Lines        12225    12226       +1     
  Branches      1746     1746              
===========================================
  Hits          7625     7625              
- Misses        4284     4285       +1     
  Partials       316      316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rithviknishad rithviknishad linked an issue Mar 25, 2024 that may be closed by this pull request
@vigneshhari vigneshhari merged commit 0d34f12 into staging Mar 25, 2024
9 of 11 checks passed
@vigneshhari vigneshhari deleted the fix-discharged-csv-export branch March 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discharge patients CSV export results in empty list
3 participants