Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issues with patient annotate + distinct not implemented for csv export #1999

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 21, 2024

Warning

Base branch is staging

Proposed Changes

  • Skip ordering filter for patient list if CSV Export

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.37%. Comparing base (6d68486) to head (9d1be32).

Files Patch % Lines
care/facility/api/viewsets/patient.py 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1999      +/-   ##
===========================================
- Coverage    62.38%   62.37%   -0.02%     
===========================================
  Files          221      221              
  Lines        12219    12225       +6     
  Branches      1744     1746       +2     
===========================================
+ Hits          7623     7625       +2     
- Misses        4281     4284       +3     
- Partials       315      316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 8358849 into staging Mar 22, 2024
9 of 11 checks passed
@vigneshhari vigneshhari deleted the fix-patient-csv-export branch March 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants