Duplicated .pdf in the discharge summary file names

[krassowska]

Proposed Changes

• Remove ".pdf" from discharge summary file name
• Add comments in the FileUpload that name should not contain extension while internal_name should include it
• Add test for discharge summary name

Associated Issue

• Fixes Generated discharge summary file names ending with .pdf.pdf #1961

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: care/facility/utils/reports/discharge_summary.py

Function	Unhandled Issue
generate_and_upload_discharge_summary	ClientError: An error occurred (PermanentRedirect) when calling the PutObject operation: The bucket you are at... care... Event Count: 66

---

_{Did you find this useful? React with a 👍 or 👎}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.38%. Comparing base (3e3b65d) to head (a62f73c).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1978      +/-   ##
===========================================
+ Coverage    62.32%   62.38%   +0.06%     
===========================================
  Files          221      221              
  Lines        12219    12219              
  Branches      1744     1744              
===========================================
+ Hits          7615     7623       +8     
+ Misses        4291     4281      -10     
- Partials       313      315       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.