Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bed assignment validation for admission #1945

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix bed assignment validation for admission #1945

merged 3 commits into from
Mar 5, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Mar 5, 2024

Fixes ohcnetwork/care_fe#7340

This pull request fixes the bed assignment validation for admission. Previously, if a patient did not have a bed assigned and the suggestion was 'A', an error would occur. This PR ensures that the error is raised only when the patient does not have a bed assigned and the suggestion is 'A'.

@Ashesh3 Ashesh3 changed the base branch from master to staging March 5, 2024 12:36
@nihal467
Copy link
Member

nihal467 commented Mar 5, 2024

LGTM

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.95%. Comparing base (aba0849) to head (89f9749).

❗ Current head 89f9749 differs from pull request most recent head d37985a. Consider uploading reports for the commit d37985a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1945   +/-   ##
========================================
  Coverage    61.95%   61.95%           
========================================
  Files          221      221           
  Lines        12171    12171           
  Branches      1736     1736           
========================================
  Hits          7540     7540           
  Misses        4325     4325           
  Partials       306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak added the P1 High priority; urgent label Mar 5, 2024
@sainak sainak requested a review from gigincg March 5, 2024 13:26
@gigincg gigincg merged commit bcaaa33 into staging Mar 5, 2024
5 checks passed
@gigincg gigincg deleted the fix-bed-check branch March 5, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create a log update for domiciliary care patient
6 participants