-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add django filter for patient review missed #1938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need tests
@rithviknishad , Do I have to do them? |
yes |
@sainak Could you please guide me a little on how to write tests for the changes I have made? |
Hey @sainak, I have added test for the review missed filter, could you please review them? |
In the test, I am checking inside a loop whether every patient, in the response returned, satisfies the condition for a missed review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1938 +/- ##
===========================================
- Coverage 62.60% 62.55% -0.05%
===========================================
Files 223 223
Lines 12277 12278 +1
Branches 1750 1754 +4
===========================================
- Hits 7686 7681 -5
- Misses 4269 4274 +5
- Partials 322 323 +1 ☔ View full report in Codecov by Sentry. |
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins