Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: fix events create and serilaize choice fields #1897

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Feb 19, 2024

Proposed Changes

  • fix events not created
  • serialize choice fields display

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (63ff210) 61.86% compared to head (48ea2d5) 61.83%.

Files Patch % Lines
care/facility/events/handler.py 88.23% 1 Missing and 1 partial ⚠️
care/utils/event_utils.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   61.86%   61.83%   -0.04%     
==========================================
  Files         221      221              
  Lines       12145    12163      +18     
  Branches     1728     1735       +7     
==========================================
+ Hits         7514     7521       +7     
- Misses       4324     4334      +10     
- Partials      307      308       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gigincg gigincg merged commit 411e89c into master Feb 19, 2024
10 of 11 checks passed
@gigincg gigincg deleted the sainak/fix/events-module branch February 19, 2024 14:41
@gigincg gigincg restored the sainak/fix/events-module branch February 19, 2024 14:41
@gigincg gigincg deleted the sainak/fix/events-module branch February 19, 2024 14:41
Copy link

sentry-io bot commented Feb 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrityError: null value in column "consultation_id" violates not-null constraint /api/v1/patient/{patient_external_id}/notes/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants