Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryset filters for asset daily rounds #1879

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Feb 8, 2024

This pull request fixes the queryset filters for asset daily rounds. It ensures that the filters are correctly applied to the queryset, allowing asset users to access and filter daily rounds based on their current location.

regression from #1760

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5b51a1a) 61.68% compared to head (b61fe2d) 61.65%.

Files Patch % Lines
care/utils/queryset/facility.py 0.00% 2 Missing and 2 partials ⚠️
care/utils/queryset/consultation.py 25.00% 2 Missing and 1 partial ⚠️
care/facility/api/serializers/daily_round.py 60.00% 1 Missing and 1 partial ⚠️
care/facility/api/viewsets/daily_round.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
- Coverage   61.68%   61.65%   -0.03%     
==========================================
  Files         212      212              
  Lines       11685    11689       +4     
  Branches     1657     1658       +1     
==========================================
- Hits         7208     7207       -1     
- Misses       4180     4184       +4     
- Partials      297      298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 94cadaf into master Feb 8, 2024
9 of 11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/daily-rounds branch February 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants