Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update username validator #1865

Merged
merged 4 commits into from
Feb 10, 2024
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Jan 31, 2024

This pull request updates the username validator in the User model. The new validator ensures that the username meets the required criteria, including length, allowed characters, and consecutive characters. It also includes unit tests to validate the validator's behavior.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (553b2a5) 61.66% compared to head (9515dfb) 61.67%.
Report is 10 commits behind head on master.

❗ Current head 9515dfb differs from pull request most recent head 4e8a369. Consider uploading reports for the commit 4e8a369 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   61.66%   61.67%   +0.01%     
==========================================
  Files         212      212              
  Lines       11691    11695       +4     
  Branches     1658     1659       +1     
==========================================
+ Hits         7209     7213       +4     
  Misses       4184     4184              
  Partials      298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 5a087e1 into master Feb 10, 2024
9 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/username-validation branch February 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants