-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min_quntity to facilityinventorysummary and add migration #1763
Conversation
@rithviknishad @vigneshhari can you check this PR when you get a chance. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No model changes required. Min qty field is already stored in the table, you just have to serialize that.
This reverts commit eb05b2d.
…uired field based on min_quantity configured or default
@rithviknishad can you check now? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasudevravula let me rephrase the issue's requirements for you more clearly
Currently we can set min. qty required for items from this page:
https://care.ohc.network/facility/915b2a99-3ee8-4ed4-b086-cfe3b4ca6148/inventory/min_quantity/set
And we can see the stocks available in the inventory at present from here
https://care.ohc.network/facility/915b2a99-3ee8-4ed4-b086-cfe3b4ca6148/inventory
The requirement is to show the set min. qty for those items in the manage inventory page itself. This would require to add an additional serializer READ ONLY field, that'll show this data along with listing the inventory items.
@rithviknishad Thanks for the detailed explanation of the issue. I'm checking to make the changes, can you please assign the API and UI issues to me when you get a chance? |
Proposed Changes
Associated Issue
1721
6621
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins