Fix edge case for middleware hostname override in asset.py

[Ashesh3]

This pull request addresses a subtle yet important issue in the asset management API, specifically in the operate_assets method of care/facility/api/viewsets/asset.py and the check_asset_status function in care/facility/tasks/asset_monitor.py. The modification ensures a more reliable fallback mechanism for retrieving the middleware hostname associated with assets.

Previously, the code utilized the asset.meta.get("middleware_hostname", asset.current_location.middleware_address) pattern. This approach, however, did not account for scenarios where asset.meta['middleware_hostname'] could be an empty string. In such cases, the intended fallback to asset.current_location.middleware_address was bypassed, inadvertently defaulting to asset.current_location.facility.middleware_address due to the outer or condition.

The current update addresses this issue by repositioning the fallback logic. Instead of relying on the get method's default value, the code now explicitly checks for the truthiness of the middleware_hostname retrieved from asset.meta. This change ensures that if middleware_hostname is an empty string, the code will correctly fall back to asset.current_location.middleware_address, and subsequently to asset.current_location.facility.middleware_address if needed.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[nihal467]

LGTM ,

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f287b46) 60.76% compared to head (abf5523) 60.76%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1733   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         210      210           
  Lines       11530    11530           
  Branches     1642     1642           
=======================================
  Hits         7006     7006           
  Misses       4283     4283           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.