-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename admission_date
to encounter_date
and clean column
#1728
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
+ Coverage 61.38% 61.40% +0.01%
==========================================
Files 211 211
Lines 11595 11595
Branches 1660 1658 -2
==========================================
+ Hits 7118 7120 +2
+ Misses 4205 4204 -1
+ Partials 272 271 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few changes
LGTM |
Resolve Conflicts. |
Proposed Changes
admission_date
toencounter_date
encounter_date
for all consultationsencounter_date
tocreated_date
for existing consultations that are not admission/domiciliary care orencounter_date
isnull
.encounter_date
is non-nullable and defaults tonow
Associated Issue
admission_date
based on consultation suggestion care_fe#6669admission_date
toencounter_date
and white label the field based on decision after consultation choice care_fe#6668Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins