Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list and detail serializer with tests for shifting module #1549

Closed

Conversation

GeekGawd
Copy link
Contributor

@GeekGawd GeekGawd commented Aug 22, 2023

Proposed Changes

  • Add list and detail serializer with tests for shifting module
  • Add tests and comments

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (2829067) to head (b8c27c3).
Report is 380 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1549      +/-   ##
===========================================
+ Coverage    59.11%   59.56%   +0.45%     
===========================================
  Files          207      207              
  Lines        11264    11318      +54     
  Branches      1599     1602       +3     
===========================================
+ Hits          6659     6742      +83     
+ Misses        4405     4369      -36     
- Partials       200      207       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak added the to-be-closed PRs with no updates in the last 3 weeks will be closed label May 12, 2024
@vigneshhari vigneshhari reopened this Aug 23, 2024
@vigneshhari vigneshhari requested a review from a team as a code owner August 23, 2024 08:29
vigneshhari added a commit that referenced this pull request Aug 23, 2024
…2392)

* Add list and detail serializer with tests for shifting module

* viewset improve select_related for list action

* Fix Test Cases

* Update care/facility/api/serializers/shifting.py

* Fix Linting

* Fix Linting and tests

---------

Co-authored-by: Suyash Singh <suyashsingh.stem@gmail.com>
Co-authored-by: GeekGawd <89455838+GeekGawd@users.noreply.github.com>
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
@vigneshhari
Copy link
Member

This MR has been merged separately. Ref #2392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-be-closed PRs with no updates in the last 3 weeks will be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants