Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds chapter, root_block, root_category columns to meta_icd11_diagnosis DB table #1448

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Adds chapter, root_block, root_category columns to meta_icd11_diagnosis DB table #1448

merged 3 commits into from
Jul 13, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 12, 2023 •
edited
Loading

Proposed Changes

image
  • The full-scan of icd11 when finding roots is never executed as the icd11.json is already sorted.
image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad
Copy link
Member Author

Following columns to be added too:

root_category
root_block
root_label -> chapter

cc: @gigincg

@rithviknishad rithviknishad requested a review from sainak July 12, 2023 13:49
@rithviknishad rithviknishad changed the title Adds root_label (top-most category) column to meta_icd11_diagnosis DB Table Adds category, root_block, root_category columns to meta_icd11_diagnosis DB table Jul 12, 2023
@rithviknishad rithviknishad changed the title Adds category, root_block, root_category columns to meta_icd11_diagnosis DB table Adds chapter, root_block, root_category columns to meta_icd11_diagnosis DB table Jul 12, 2023
@vigneshhari vigneshhari merged commit 0f4486a into master Jul 13, 2023
@vigneshhari vigneshhari deleted the rithviknishad/meta_icd11/add_root_label branch July 13, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

@sainak sainak Awaiting requested review from sainak

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rithviknishad @vigneshhari @sainak