Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: pin to pydantic v1 for fhir.resources #1418

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 1, 2023

Proposed Changes

  • fhir.resources is incompatible with pydantic v2, so pinned it to v1

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak
Copy link
Member Author

sainak commented Jul 1, 2023

@khavinshankar this issue is present in the latest version of fhir.resources as well, this compatibility check needs to be done on the upstream itself, plese verify and file an issue on fhir.resources repo if necessary

@sainak sainak added waiting-for-review P1 High priority; urgent labels Jul 1, 2023
@vigneshhari vigneshhari merged commit 85a5c5d into master Jul 1, 2023
@vigneshhari vigneshhari deleted the sainak/fix/deps-issue branch July 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fhir.resources incompatible with pydantic v2
4 participants