Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set discharge_date same as death_datetime if dischrged as expired ("EXP") #1414

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Set discharge_date same as death_datetime if dischrged as expired ("EXP") #1414

merged 3 commits into from
Jun 28, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • When discharging, instead of using now() as discharge_date, its kept same as death_datetime
  • Migrations for old datas for the same.

Associated Issue

image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad requested review from vigneshhari and sainak and removed request for vigneshhari June 27, 2023 14:17
@vigneshhari
Copy link
Member

@sainak review required.

@vigneshhari vigneshhari merged commit 41f52c9 into master Jun 28, 2023
@vigneshhari vigneshhari deleted the fix#1403 branch June 28, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@sainak sainak sainak approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

discharge_date for discharged as expired is automatically current date time instead of death_datetime
3 participants
@rithviknishad @vigneshhari @sainak