Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use signals to update patient and bed count of facilities #1349

Closed
wants to merge 2 commits into from

Conversation

sainak
Copy link
Member

@sainak sainak commented Jun 6, 2023

Proposed Changes

  • create fields for patient and bed counts in facility
  • create signals to update the count on changes

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner June 6, 2023 10:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari
Copy link
Member

could you move all the syncing bits to a common utility function, in the future we would want a task running once a day to calculate drift, correct it, and report it. Think of a common framework since we would have a lot of these caches

@sainak sainak force-pushed the sainak/issue1334 branch from 1a0f543 to e40331f Compare June 12, 2023 07:18
@sainak sainak force-pushed the sainak/issue1334 branch from e40331f to 0759354 Compare June 12, 2023 09:18
@Ashesh3
Copy link
Member

Ashesh3 commented Oct 3, 2023

@sainak is this ready to review or still pending changes?

@sainak
Copy link
Member Author

sainak commented Oct 3, 2023

@sainak is this ready to review or still pending changes?

This was a kind of poc but, you can review and give feedbacks or suggest better ways to handle this problem.

cc: @vigneshhari

@sainak sainak deleted the sainak/issue1334 branch January 21, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants