HCX Communications #1346
HCX Communications #1346
Conversation
|
SonarCloud Quality Gate failed.
|
| @@ -89,3 +92,33 @@ def post(self, request, *args, **kwargs): | |||
| ) | |||
|
|
|||
| return Response({}, status=status.HTTP_202_ACCEPTED) | |||
|
|
|||
|
|
|||
| class CommunicationRequestView(GenericAPIView): | |||
There was a problem hiding this comment.
This is actually handled using a custom authentication class (https://github.com/coronasafe/care/blob/b64538337000442573be7fda175893b37dbb7447/config/authentication.py#L159) in a different pr (https://github.com/coronasafe/care/pull/1229/files)
There was a problem hiding this comment.
Can we have all related changes in a single PR?
|
Fix Conflicts, add tests and fix linting. |
67d07a4 to
ec1df6c
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
==========================================
- Coverage 56.66% 56.58% -0.09%
==========================================
Files 195 199 +4
Lines 9861 10017 +156
Branches 1655 1682 +27
==========================================
+ Hits 5588 5668 +80
- Misses 4219 4295 +76
Partials 54 54
☔ View full report in Codecov by Sentry. |
| queryset = queryset.filter(claim__policy__patient__facility__state=user.state) | ||
| elif user.user_type >= User.TYPE_VALUE_MAP["DistrictLabAdmin"]: | ||
| queryset = queryset.filter( | ||
| claim__policy__patient__facility__district=user.district |
There was a problem hiding this comment.
@vigneshhari As I'm doing these many joins, does this have any performance implications?
There was a problem hiding this comment.
Should be fine, since we cant really do anything else here. until we build a better permission system, let this stay .
Update deployment-branch.yaml
Update deployment-branch.yaml
Update deployment-branch.yaml
Proposed Changes
@coronasafe/code-reviewers
Merge Checklist
/docs