Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge and update staging deployment job #1343

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Jun 2, 2023

Proposed Changes

  • merge staging api and celery deployment into one job to avoid creating duplicate deployment status on github
  • update name and domain of staging deployment

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner June 2, 2023 16:25
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (96222fc) 56.71% compared to head (82a0648) 56.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files         199      199           
  Lines        9905     9905           
  Branches     1654     1654           
=======================================
  Hits         5618     5618           
  Misses       4232     4232           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sainak sainak force-pushed the sainak/deployment-updates branch from 82a0648 to 0edc5d3 Compare June 6, 2023 11:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mathew-alex mathew-alex merged commit 65e5cec into master Jun 6, 2023
@sainak sainak deleted the sainak/deployment-updates branch June 6, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants