Delete notifications older than 90 days

[yaswanthsaivendra]

Proposed Changes

• created a periodic task to delete notifications that are older than 90 days.

Associated Issue

• Fixes Periodically hard delete Notification records that are older than 90 days. #1320

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[yaswanthsaivendra]

@rithviknishad , @vigneshhari
Please review!!

[vigneshhari]

Can you create a test for this as well? Once you have the tests added we can merge.

[yaswanthsaivendra]

Can you create a test for this as well? Once you have the tests added we can merge.

Yes, added the tests. Please check
Yesterday for the first I got to know about mocking . So Can u share ur opinion on mocking database interactions. Is it good or bad. but I observed that it decreases the run time of tests alot.

[vigneshhari]

You could have gotten away without mocking in these tests by using the update method of the django queryset ( they do not invoke the save methods and the created timestamps can be added manually "to my knowledge" ), even in this case, we are not mocking the database interactions, we are just mocking the time method.
In almost all cases we would not want to mock the database, the database is what we are usually testing against. mocking is useful when there is an external service involved, like an SMS API or an integration with an API, in our unit tests we mock all the responses they can give ( success, failure, exception ) and test if the function we wrote handles every case correctly.

[yaswanthsaivendra]

You could have gotten away without mocking in these tests by using the update method of the django queryset ( they do not invoke the save methods and the created timestamps can be added manually "to my knowledge" ), even in this case, we are not mocking the database interactions, we are just mocking the time method. In almost all cases we would not want to mock the database, the database is what we are usually testing against. mocking is useful when there is an external service involved, like an SMS API or an integration with an API, in our unit tests we mock all the responses they can give ( success, failure, exception ) and test if the function we wrote handles every case correctly.

Yaa ik that i haven't mocked any database interactions in the pushed code . I just asked it coz I first wrote the test by mocking database interactions, later i realised that isn't a gud idea. So i changed it. Thanks for sharing ur opinion. 😄