Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused hba1c field from patient consultation #1309

Merged
merged 7 commits into from
Jul 20, 2023
Merged

remove unused hba1c field from patient consultation #1309

merged 7 commits into from
Jul 20, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented May 23, 2023 •
edited
Loading

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner May 23, 2023 11:02
@sainak sainak closed this May 25, 2023
@sainak sainak deleted the sainak/issue1200 branch May 25, 2023 11:06
@sainak sainak restored the sainak/issue1200 branch May 25, 2023 11:07
@sainak sainak reopened this May 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari
Copy link
Member

Can i get an ops confirmation for this? This would remove all historical data for this field.
cc @gigincg @aparnacoronasafe

@sainak sainak force-pushed the sainak/issue1200 branch from 8c9958d to 80dbf3f Compare June 24, 2023 13:10
@sainak sainak changed the title remove HBA1C field from consultation model make HBA1C field read only Jun 24, 2023
@sainak sainak force-pushed the sainak/issue1200 branch from 80dbf3f to 9335dbc Compare July 3, 2023 09:55
@sainak sainak changed the title make HBA1C field read only remove unused hba1c field from patient consultation Jul 3, 2023
@sainak sainak force-pushed the sainak/issue1200 branch from 9335dbc to 09a0f7e Compare July 3, 2023 09:59
@sainak sainak requested a review from vigneshhari July 3, 2023 10:00
@gigincg
Copy link
Member

gigincg commented Jul 12, 2023

@vigneshhari @sainak We're good to remove the field. It was never fully implemented to begin with

@sainak
update migration
c2271d3 
Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@vigneshhari vigneshhari merged commit d58c69b into master Jul 20, 2023
@vigneshhari vigneshhari deleted the sainak/issue1200 branch July 20, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive HBA1C field in consultation table
4 participants
@sainak @vigneshhari @gigincg @rithviknishad