Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Shifting #1276

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

Ashesh3
Copy link
Contributor

@Ashesh3 Ashesh3 commented Apr 27, 2023

Proposed Changes

  • Fixes typo origin_facility to orgin_facility
  • Adds Canceled shifting status to be ignored when checking for existing shifting records during creation of a new record.
  • Fixes an edge case where notification handler was crashing when no facility object was given.

@coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team as a code owner April 27, 2023 13:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (df7a4ed) 56.29% compared to head (a6ba4ba) 56.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   56.29%   56.28%   -0.02%     
==========================================
  Files         195      195              
  Lines        9582     9584       +2     
  Branches     1609     1610       +1     
==========================================
  Hits         5394     5394              
- Misses       4133     4135       +2     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/serializers/shifting.py 49.65% <ø> (ø)
care/utils/notification_handler.py 16.74% <0.00%> (-0.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gigincg gigincg merged commit acac857 into ohcnetwork:master Apr 27, 2023
@gigincg
Copy link
Member

gigincg commented Apr 27, 2023

@Ashesh3 Can you make a separate issue to replace all orgin_facility to origin_facility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants