Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow transfer for patients defaults to true if peacetime, else false #1269

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Allow transfer for patients defaults to true if peacetime, else false #1269

merged 4 commits into from
Apr 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 24, 2023 •
edited
Loading

Proposed Changes

  • Allow transfer is defaulted to true if PEACETIME, defaulted to false if not PEACETIME.

When PEACETIME=True

image

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner April 24, 2023 14:37
@rithviknishad rithviknishad added P1 High priority; urgent waiting-for-review labels Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d9ab75f) 56.23% compared to head (24783b4) 56.24%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   56.23%   56.24%           
=======================================
  Files         195      195           
  Lines        9616     9618    +2     
  Branches     1613     1613           
=======================================
+ Hits         5408     5410    +2     
  Misses       4153     4153           
  Partials       55       55
Impacted Files Coverage Δ
care/facility/api/serializers/patient.py 56.52% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gigincg
gigincg requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@gigincg gigincg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in the serializer instead & disable allow_transfer when warmode is enabled

cc: @vigneshhari

@rithviknishad rithviknishad requested a review from gigincg April 28, 2023 09:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad changed the title Default allow transfer for patients Allow transfer for patients defaults to true if peacetime, else false Apr 28, 2023
@vigneshhari vigneshhari merged commit b180288 into master Apr 28, 2023
@sainak sainak deleted the allow-transfer-default branch June 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default- allow transfer
4 participants
@rithviknishad @codecov-commenter @gigincg @vigneshhari