Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skills to UserAssignedSerializer #1188

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Feb 12, 2023

Proposed Changes

  • Adds reverse field in UserAssignedSerializer: userskills_set as skills field
  • Some formatting changes because commit prehook mandates it.

Associated Issue

image

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner February 12, 2023 04:41
@rithviknishad rithviknishad marked this pull request as draft February 12, 2023 04:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 55.85% // Head: 55.86% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a567cf8) compared to base (b12ec95).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   55.85%   55.86%           
=======================================
  Files         177      177           
  Lines        8829     8831    +2     
  Branches     1521     1521           
=======================================
+ Hits         4931     4933    +2     
  Misses       3844     3844           
  Partials       54       54           
Impacted Files Coverage Δ
care/users/api/serializers/user.py 59.47% <100.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@vigneshhari @gigincg can you review this ASAP

@gigincg gigincg merged commit a4fefb1 into master Feb 12, 2023
@gigincg
Copy link
Member

gigincg commented Feb 12, 2023

@rithviknishad Please take care of the FE Changes needed to start using this, if any.

@rithviknishad
Copy link
Member Author

@gigincg I've already made the PR: ohcnetwork/care_fe#4805

@vigneshhari
Copy link
Member

@rithviknishad create an issue to optimize the query, not sure what kind of query is being produced by django to fetch the many to many relation

@sainak sainak deleted the adds-skills-to-user-assigned-serializer branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staff unable to view skills of other users (required in Doctor Connect)
5 participants