return file extension in file_upload list and retrieve views

[sainak]

Proposed Changes

return file extension in file_upload list and retrieve views

@coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

[codecov-commenter]

Codecov Report

Merging #1019 (04affa5) into master (1c2b1ac) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   53.80%   53.80%           
=======================================
  Files         180      180           
  Lines        8916     8917    +1     
  Branches     1506     1521   +15     
=======================================
+ Hits         4797     4798    +1     
  Misses       4070     4070           
  Partials       49       49           

Impacted Files	Coverage Δ
care/facility/api/serializers/file_upload.py	45.65% <50.00%> (ø)
care/users/api/viewsets/change_password.py	62.96% <0.00%> (+1.42%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[vigneshhari]

Let's not give the internal name out, our goal here was to break the relationship between the file name and the patient in the unlikely case our buckets are attacked.
Let's serialize only the extension.

[sainak]

Let's not give the internal name out, our goal here was to break the relationship between the file name and the patient in the unlikely case our buckets are attacked. Let's serialize only the extension.

yeah I thought returning the extension would be a better solution
do you have any suggestions for implementing that?
I have 2 implementations in mind

• making the query return the extension
• make a model method to return extension or file type

[vigneshhari]

the model method sounds good enough. make sure you handle the edge cases.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication