Make stderr redirection compatible with Fish 3.0. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagebind
reviewed
Jan 14, 2019
| @@ -1,3 +1,3 @@ | |||
| function vcs.dirty | |||
| command hg summary 2>/dev/null | command grep -q 'commit: (clean)' ^/dev/null | |||
| command hg summary 2> /dev/null | command grep -q 'commit: (clean)' 2> /dev/null | |||
There was a problem hiding this comment.
Hah, half the command used 2> and the other half used ^...
There was a problem hiding this comment.
yeah, there were a couple like that :)
sagebind
approved these changes
Jan 14, 2019
|
Whoops. Lousy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fish has deprecated
^as a shortcut for stderr redirection in 3.0. Replace it with the morecompatible
2>.See oh-my-fish/oh-my-fish#609 and oh-my-fish/oh-my-fish#618