Support Linux aarch64 via sse2neon #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It builds on Linux x86_64 natively and on Linux ARM64 via emulation (QEMU) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
```
blksrc.cc: In constructor 'Block::Block(const Seq*, INT, bool)':
blksrc.cc:400:2: error: 'prelude' was not declared in this scope
400 | prelude = max_width() * (istron? 3: 1) - 1;
| ^~~~~~~
blksrc.cc:404:2: error: 'margin' was not declared in this scope
404 | margin = prelude;
| ^~~~~~
```
Replace all usages of __aarch64__ with __ARM_NEON
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
|
Successful CI run at my fork: https://github.com/martin-g/spaln/actions/runs/8833642629 |
…versions The overwrite of CXX is ugly though due to https://github.com/ogotoh/spaln/blob/db1f024fb36aa0143bf6a92ae7fbe6b79df70d0a/src/Makefile.in#L16 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to martin-g/bioconda-recipes
that referenced
this pull request
May 7, 2024
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to martin-g/bioconda-recipes
that referenced
this pull request
May 7, 2024
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to martin-g/bioconda-recipes
that referenced
this pull request
May 7, 2024
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
This is a PR that uses https://github.com/DLTcollab/sse2neon/ to translate SSE to NEON.
It basically disables the usage of arm_neon.h and uses the sse4.1 impls for aarch64.
If the PR is accepted then all the code for
__ARM_NEON_NOcould be removed!