Freerdp 3 and casts #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akallabeth
commented
Apr 23, 2021
- Add compile time option to link freerdp3
- Remove function pointer casts
Cast function pointer arguments in implementation so that changes in functin pointer arguments emit warnings
|
@hardening benefit of d7e9840 is that if we change something with the function pointers we immediately get a compiler warning whereas the previous casts did hide all changes. |
|
@akallabeth why the massiv reformatting? |
|
@bmiklautz you mean the reordered includes or the removed function pointer casts? |
|
@bmiklautz the answer for the removed function pointer casts is easy, so that changes to the function signature will spill warnings when compiled |
05344b2 to
b8e6113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.