Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed debian compilation warnings. #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed debian compilation warnings. #37

wants to merge 2 commits into from

Conversation

akallabeth
Copy link
Contributor

  • Fix some duplicate defined symbols (GIT_REVISION)
  • Fix some string bound warnings (sprintf et al, use c++ stringstream instead)
  • Fix some deprecation warnings

hardening
hardening reviewed Nov 19, 2020
View reviewed changes
rdp-server/peer.c
@@ -980,7 +980,13 @@ static int pre_connect_handler(int mask, int fd, HANDLE handle, void *data) {
}

/* we have the magic bytes, let's read the RDPEPS blob */
read(peer->sockfd, pre_blob, sizeof(pre_blob_magic)); /* skip the pre blob magic */
status = read(peer->sockfd, pre_blob,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the logic to please the compiler with formal checks, anyway perhaps we should complain super loudly (something more alarmous than just error skipping pre blob magic) when we have peek bytes from the socket, and when really reading them, we figure it's something different...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did continue the style like any other check before or after is done. (message wise)

hardening
hardening approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardening hardening hardening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akallabeth @hardening