Use Freerdp for h264 encoding #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c1c7f8 to
e875a99
Compare
bmiklautz
requested changes
Oct 22, 2020
| # Build unit tests | ||
| option(BUILD_TESTING "Build unit tests" OFF) | ||
|
|
||
| # Build with OpenH264 support | ||
| option(WITH_OPENH264 "Add support for H.264 encoding" ON) |
There was a problem hiding this comment.
I would prefer to stick with the H.264 encoder by default for now.
hardening
suggested changes
Oct 22, 2020
e875a99 to
0c99154
Compare
|
@bmiklautz changed the default to current OpenH264 |
0c99154 to
0892662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to use the freerdp h264 backend for frame encoding. (Requires H264 support compiled into freerdp)