prov/efa: Remove rxr_ep->rdm_ep #8418
Conversation
f9d2b9d to
a7fecf9
Compare
prov/efa/src/efa_base_ep.h
Outdated
| /* | ||
| * Specific flags and attributes for shm provider | ||
| */ | ||
| #define EFA_SHM_MAX_AV_COUNT (256) |
There was a problem hiding this comment.
EFA_SHM_XXX should not have been moved.
There was a problem hiding this comment.
I only moved things necessary for efa_base_ep now
a7fecf9 to
227a38e
Compare
227a38e to
ee823d5
Compare
ee823d5 to
cd60297
Compare
| #include "ofi_util.h" | ||
| #include "ofi_file.h" | ||
|
|
||
| #include "efa_av.h" |
There was a problem hiding this comment.
Is this still needed here?
There was a problem hiding this comment.
yes. efa_base_ep.c isn't importing efa_av.h
also, if we're going to be so careful with imports, we need to spend a week cleaning up the rest of the code base
There was a problem hiding this comment.
yes.
efa_base_ep.cisn't importingefa_av.h
Does efa.h not include efa_av.h?
also, if we're going to be so careful with imports
It's not really about carefulness in the sense that it's a correctness thing (it will function just fine); it's more of a code quality thing.
There was a problem hiding this comment.
Does
efa.hnot includeefa_av.h?
Not directly, no. Is this your end goal: efa.h includes every DGRAM header and all DGRAM C files only include efa.h? That's currently not the case. We can make a task to clean up the includes in this style, if you wish.
cd60297 to
6eb50e6
Compare
RDM endpoint now uses rxr_ep->base_ep.av Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This commit removes the rdm_ep member of rxr_ep. The RDM endpoint no longer uses the DGRAM endpoint as a lower endpoint Signed-off-by: Sai Sunku <sunkusa@amazon.com>
6eb50e6 to
7a245ab
Compare
This commit removes the rdm_ep member of rxr_ep. The RDM endpoint no longer uses the DGRAM endpoint as a lower endpoint