-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prov/efa: Remove fi_sendmsg/recvmsg but still use efa_ep's qp and av #8391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change to efa_send_wr
and efa_recv_wr
you need to update how efa_ep->send_wr_bufpool
and efa_ep->recv_wr_pool
is created. Specifically the entry size should be just sizeof(efa_send_wr)
and sizeof(efa_recv_wr)
But the DGRAM provider needs memory for the SGEs if a higher applications calls the DGRAM provider directly |
df472e9
to
05c71be
Compare
7f2532a
to
e110a3e
Compare
I do not understand the comment. Current code is: libfabric/prov/efa/src/efa_ep.c Line 674 in 1eb9905
The reason to add |
e110a3e
to
a0dcbf5
Compare
OK I understand now. Fixed. |
65ef34a
to
62df336
Compare
For SHM EP, use fi_sendv and fi_recvv For EFA EP * Allocate ibv_send_wr and ibv_recv_wr in rxr_pkt_entry * Still use efa_ep->qp, efa_ep->av and efa_ep->xmit_more_wr* * Directly call efa_post_flush or ibv_post_recv in rxr_pkt_entry.c Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This variable always has the same value as the loop variable Signed-off-by: Sai Sunku <sunkusa@amazon.com>
62df336
to
ad50b21
Compare
This commit fixes a bug that was introduced in ofiwg#8391 Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This commit fixes a bug that was introduced in ofiwg#8391 Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This commit fixes a bug that was introduced in ofiwg#8391 Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This commit fixes a bug that was introduced in ofiwg#8391 Signed-off-by: Sai Sunku <sunkusa@amazon.com>
For SHM EP, use fi_sendv and fi_recvv
For EFA EP
Signed-off-by: Sai Sunku sunkusa@amazon.com