Remove un-needed sfences. See the HAS for more information (#18)

* Remove un-needed sfences.
ofiwg · Jun 28, 2021 · bc7e25a · bc7e25a
1 parent 5674821
commit bc7e25a
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 19 deletions.
diff --git a/prov/opa1x/include/rdma/opa1x/fi_opa1x_hfi1_transport.h b/prov/opa1x/include/rdma/opa1x/fi_opa1x_hfi1_transport.h
@@ -177,8 +177,6 @@ ssize_t fi_opa1x_hfi1_tx_inject (struct fid_ep *ep,
 
 	tmp[7] = scb[7] = tag;
 
-	fi_opa1x_compiler_msync_writes();
-
 	FI_OPA1X_HFI1_CHECK_CREDITS_FOR_ERROR(opa1x_ep->tx.pio_credits_addr);
 
 	/* consume one credit */
@@ -454,7 +452,6 @@ ssize_t fi_opa1x_hfi1_tx_send_egr (struct fid_ep *ep,
 		FI_OPA1X_HFI1_CONSUME_SINGLE_CREDIT(pio_state);
 	}
 
-	fi_opa1x_compiler_msync_writes();
 	FI_OPA1X_HFI1_CHECK_CREDITS_FOR_ERROR(opa1x_ep->tx.pio_credits_addr);
 
 	if (reliability != OFI_RELIABILITY_KIND_NONE) {	/* compile-time constant expression */

diff --git a/prov/opa1x/include/rdma/opa1x/fi_opa1x_reliability.h b/prov/opa1x/include/rdma/opa1x/fi_opa1x_reliability.h
@@ -474,7 +474,6 @@ fi_opa1x_reliability_client_replay_allocate(struct fi_opa1x_reliability_client_s
 			abort();
 		}
 #endif
-		fi_opa1x_compiler_msync_writes();
 	}
 	replay->active = 1;
 

diff --git a/prov/opa1x/src/fi_opa1x_hfi1.c b/prov/opa1x/src/fi_opa1x_hfi1.c
@@ -457,8 +457,6 @@ void fi_opa1x_hfi1_rx_rzv_rts (struct fid_ep *ep,
 
 		FI_OPA1X_HFI1_CONSUME_SINGLE_CREDIT(pio_state);
 
-		fi_opa1x_compiler_msync_writes(); /* TODO: not needed if using avx512 */
-
 		if (reliability != OFI_RELIABILITY_KIND_NONE) {		/* compile-time constant expression */
 			replay->payload[0] = tmp[0];
 			replay->payload[1] = tmp[1];
@@ -690,9 +688,6 @@ void fi_opa1x_hfi1_rx_rzv_cts (struct fid_ep *ep,
 				/* update the shared hfi txe state */
 				opa1x_ep->tx.pio_state->qw0 = pio_state.qw0;
 
-				fi_opa1x_compiler_msync_writes();
-
-
 				FI_DBG_TRACE(fi_opa1x_global.prov, FI_LOG_EP_DATA,
 					"===================================== SEND, HFI -- RENDEZVOUS DATA (end)\n");
 			} /* if !is_intranode */
@@ -1083,8 +1078,6 @@ ssize_t fi_opa1x_hfi1_tx_send_rzv (struct fid_ep *ep,
 		}
 #endif /* RZV_IMMEDIATE_BLOCK_ENABLED */
 
-		fi_opa1x_compiler_msync_writes();	/* TODO: not needed if using avx512 */
-
 		if (reliability != OFI_RELIABILITY_KIND_NONE) {	/* compile-time constant expression */
 			fi_opa1x_reliability_client_replay_register_no_update(&opa1x_ep->reliability_state,
 				addr.uid.lid, addr.reliability_rx, dest_rx, psn, replay,

diff --git a/prov/opa1x/src/fi_opa1x_reliability.c b/prov/opa1x/src/fi_opa1x_reliability.c
@@ -319,8 +319,6 @@ void fi_opa1x_hfi1_tx_reliability_inject (struct fid_ep *ep,
 	//fprintf(stderr, "%s():%d pbc: 0x%016lx\n", __func__, __LINE__, tmp[0]);
 	//fi_opa1x_hfi1_dump_stl_packet_hdr((struct fi_opa1x_hfi1_stl_packet_hdr *)&tmp[1], __func__, __LINE__);
 
-	fi_opa1x_compiler_msync_writes();
-
 	FI_OPA1X_HFI1_CHECK_CREDITS_FOR_ERROR(opa1x_ep->tx.pio_credits_addr);
 
 	/* consume one credit for the packet header */
@@ -749,8 +747,6 @@ void fi_opa1x_hfi1_rx_reliability_ack (struct fid_ep *ep,
 //fprintf(stderr, "%s():%d\n", __func__, __LINE__);
 	}
 //fprintf(stderr, "%s():%d\n", __func__, __LINE__);
-
-	fi_opa1x_compiler_msync_writes();
 }
 
 
@@ -844,8 +840,6 @@ void fi_opa1x_reliability_service_do_replay (struct fi_opa1x_reliability_service
 	//fprintf(stderr, "%s():%d pbc: 0x%016lx\n", __func__, __LINE__, tmp[0]);
 	//fi_opa1x_hfi1_dump_stl_packet_hdr((struct fi_opa1x_hfi1_stl_packet_hdr *)&tmp[1], __func__, __LINE__);
 
-	fi_opa1x_compiler_msync_writes();
-
 	FI_OPA1X_HFI1_CHECK_CREDITS_FOR_ERROR((service->tx.hfi1.pio_credits_addr));
 //fi_opa1x_hfi1_check_credits_for_error(service->tx.hfi1.pio_credits_addr, __FILE__, __func__, __LINE__);
 
@@ -896,8 +890,6 @@ void fi_opa1x_reliability_service_do_replay (struct fi_opa1x_reliability_service
 
 	/* save the updated txe state */
 	*pio_state_ptr = pio_state.qw0;
-
-	fi_opa1x_compiler_msync_writes();
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     			abort();
     		}
     #endif
-    		fi_opa1x_compiler_msync_writes();
     	}
     	replay->active = 1;
@@ Expand Down @@