Remove #define of cr_log_info needed for v2.2.2 #1276
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit, you will need to use Criterion v2.3.0 or later. Signed-off-by: Sung-Eun Choi <sungeunchoi@users.noreply.github.com>
|
👍 |
|
@sungeunchoi which criterion should the LANL-CI point to now? |
|
I've installed v2.3.1 internally. |
|
bot:lanl:retest |
|
should I install v2.2.0 of criterion at LANL? still seems to be failing |
@hppritcha Its needs 2.3.1 because 2.3.0 has a logging issue which causes gnitest to take over an hour to finish. |
|
try again with 2.3.1 |
|
grrr. libcsptr junk... |
|
now I'm getting agitated |
|
i'm merging so we will get clean CI runs at NERSC now that its switched over to criterion 2.3.1 |
hppritcha
pushed a commit
to hppritcha/libfabric
that referenced
this pull request
Mar 17, 2017
After this commit, you will need to use Criterion v2.3.0 or later. upstream merge of ofi-cray#1276 Signed-off-by: Sung-Eun Choi <sungeunchoi@users.noreply.github.com> (cherry picked from commit ofi-cray/libfabric-cray@4e45815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit, you will need to use Criterion v2.3.0 or later.
Signed-off-by: Sung-Eun Choi sungeunchoi@users.noreply.github.com