-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setuptools-scm warning raised when tag-pattern
is not defined
#67
Comments
Could we import the default value? I'm definitely open to PRs! |
edgarrmondragon
added a commit
to edgarrmondragon/hatch-vcs
that referenced
this issue
Jul 1, 2024
edgarrmondragon
added a commit
to edgarrmondragon/hatch-vcs
that referenced
this issue
Jul 1, 2024
edgarrmondragon
added a commit
to edgarrmondragon/hatch-vcs
that referenced
this issue
Jul 1, 2024
edgarrmondragon
added a commit
to edgarrmondragon/hatch-vcs
that referenced
this issue
Jul 1, 2024
…tools_scm.get_version` Closes ofek#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This package defaults to an empty string when
tag-pattern
is not defined by the user:hatch-vcs/hatch_vcs/version_source.py
Lines 17 to 26 in e186a8b
This is causing
setuptools-scm
to raise a deprecation warning:This warning is coming from https://github.com/pypa/setuptools_scm/blob/102f56a896bc4ea8d4c58d9c49f455f15310de38/src/setuptools_scm/_get_version_impl.py#L167-L175.
I don't know what the best solution is (if one's really needed) other than repeating setuptools_scm's default string value in this codebase.
The text was updated successfully, but these errors were encountered: