Now out of gas error can be handled in livenet.

[kubaplas]

#364 seems to be fixed by previous errors PR by @kpob
This one adds a test to avoid regression and adds an ExecutionError to allow handling oog error in tests.

Summary by CodeRabbit

• New Features

  • Added error handling for "Out of Gas" scenarios to improve user feedback during execution failures.

• Chores

  • Introduced a new target run-nctl in the build configuration to streamline Docker container setup for specific network uses.

[coderabbitai]

Walkthrough

In these recent updates, there are significant changes across different files to introduce an OutOfGas error type in the ExecutionError enum, enhance error handling, and add a new target in the justfile. These modifications improve error management, especially in gas-related scenarios, and enhance the build automation process.

Changes

Files/Paths	Change Summary
core/src/error.rs	Added a new OutOfGas error type with code 123 to ExecutionError enum.
examples/bin/livenet_tests.rs	Integrated error handling for gas values using the newly introduced ExecutionError.
justfile	Introduced run-nctl target to run a Docker container with specific port mappings.
odra-casper/rpc-client/src/.../casper_client	Improved error handling logic in find function by including a specific check for "Out of gas error".

Poem

Changes bloom like garden's grace,
Errors tamed in encoded space,
Docker runs through port align,
Casper listens, all divine.
🎉🎉 Code refines, a rabbit's glee,
In this digital tapestry! 🌸🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 40ddcec and 74334ee.

Files selected for processing (4)

• core/src/error.rs (1 hunks)
• examples/bin/livenet_tests.rs (2 hunks)
• justfile (1 hunks)
• odra-casper/rpc-client/src/casper_client/error.rs (4 hunks)

Files skipped from review due to trivial changes (2)

• core/src/error.rs
• justfile

Additional comments not posted (5)

examples/bin/livenet_tests.rs (2)

5-5: Import of ExecutionError is appropriate.

This import is necessary for handling the new test case that checks for the OutOfGas error, aligning with the PR objectives to enhance error handling related to gas issues.

---

23-27: Well-implemented test for OutOfGas error handling.

The test sets a very low gas limit and correctly asserts that the operation should result in an OutOfGas error. This is a good use of the newly introduced error type and helps in preventing regressions related to gas handling.

odra-casper/rpc-client/src/casper_client/error.rs (3)

7-9: Correct handling of 'Out of gas error'.

The explicit check for the "Out of gas error" message and returning the correct error type and code is a robust addition. This aligns with the PR objectives to handle gas-related errors specifically.

---

20-27: Refined schema path handling logic.

The conditional compilation for different schema paths based on the environment (test vs. non-test) is a good practice for ensuring that the correct resources are used in different contexts. This helps in maintaining the environment-specific configurations without affecting the production or test behavior.

---

141-144: Proper test coverage for 'Out of gas error'.

Adding a test case specifically for the "Out of gas error" ensures that the new error handling logic is correctly implemented and will behave as expected in production scenarios. This is crucial for maintaining robustness in error handling.