-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 version bump + small updates #448
Conversation
WalkthroughThe recent update primarily focuses on transitioning the project version from "1.0.0-rc.1" to "1.0.0". This change is reflected across various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
ROADMAP.md (1)
Line range hint
15-15
: Consider using an en dash instead of a hyphen for the range "1-2 months".- every 1-2 months + every 1–2 months
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (42)
- Cargo.toml (1 hunks)
- ROADMAP.md (2 hunks)
- examples/Cargo.toml (1 hunks)
- examples/resources/casper_contract_schemas/balance_checker_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/cross_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/dog_contract2_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/dog_contract3_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/dog_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/host_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/livenet_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/math_engine_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/mock_moderated_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/modules_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/my_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/nested_odra_types_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/owned_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/party_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/pauseable_counter_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/public_wallet_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/reentrancy_mock_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/signature_verifier_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/testing_contract_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/time_lock_wallet_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/token_manager_schema.json (1 hunks)
- examples/resources/casper_contract_schemas/token_schema.json (1 hunks)
- modules/Cargo.toml (1 hunks)
- modules/resources/casper_contract_schemas/cep18_client_contract_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/cep18_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/erc1155_receiver_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/erc1155_token_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/erc20_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/erc721_receiver_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/erc721_token_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/mock_contract_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/mock_dummy_contract_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/mock_transfer_filter_contract_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/ownable2_step_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/ownable_schema.json (1 hunks)
- modules/resources/casper_contract_schemas/wrapped_native_token_schema.json (1 hunks)
- odra-casper/proxy-caller/Cargo.toml (1 hunks)
- odra-casper/test-vm/Cargo.toml (1 hunks)
- odra-macros/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (39)
- Cargo.toml
- examples/Cargo.toml
- examples/resources/casper_contract_schemas/balance_checker_schema.json
- examples/resources/casper_contract_schemas/cross_contract_schema.json
- examples/resources/casper_contract_schemas/dog_contract3_schema.json
- examples/resources/casper_contract_schemas/dog_contract_schema.json
- examples/resources/casper_contract_schemas/host_contract_schema.json
- examples/resources/casper_contract_schemas/livenet_contract_schema.json
- examples/resources/casper_contract_schemas/math_engine_schema.json
- examples/resources/casper_contract_schemas/mock_moderated_schema.json
- examples/resources/casper_contract_schemas/modules_contract_schema.json
- examples/resources/casper_contract_schemas/my_contract_schema.json
- examples/resources/casper_contract_schemas/nested_odra_types_contract_schema.json
- examples/resources/casper_contract_schemas/owned_contract_schema.json
- examples/resources/casper_contract_schemas/party_contract_schema.json
- examples/resources/casper_contract_schemas/pauseable_counter_schema.json
- examples/resources/casper_contract_schemas/public_wallet_schema.json
- examples/resources/casper_contract_schemas/reentrancy_mock_schema.json
- examples/resources/casper_contract_schemas/testing_contract_schema.json
- examples/resources/casper_contract_schemas/time_lock_wallet_schema.json
- examples/resources/casper_contract_schemas/token_manager_schema.json
- examples/resources/casper_contract_schemas/token_schema.json
- modules/Cargo.toml
- modules/resources/casper_contract_schemas/cep18_client_contract_schema.json
- modules/resources/casper_contract_schemas/cep18_schema.json
- modules/resources/casper_contract_schemas/erc1155_receiver_schema.json
- modules/resources/casper_contract_schemas/erc1155_token_schema.json
- modules/resources/casper_contract_schemas/erc20_schema.json
- modules/resources/casper_contract_schemas/erc721_receiver_schema.json
- modules/resources/casper_contract_schemas/erc721_token_schema.json
- modules/resources/casper_contract_schemas/mock_contract_schema.json
- modules/resources/casper_contract_schemas/mock_dummy_contract_schema.json
- modules/resources/casper_contract_schemas/mock_transfer_filter_contract_schema.json
- modules/resources/casper_contract_schemas/ownable2_step_schema.json
- modules/resources/casper_contract_schemas/ownable_schema.json
- modules/resources/casper_contract_schemas/wrapped_native_token_schema.json
- odra-casper/proxy-caller/Cargo.toml
- odra-casper/test-vm/Cargo.toml
- odra-macros/Cargo.toml
Additional Context Used
LanguageTool (4)
ROADMAP.md (4)
Near line 5: Possible typo: you repeated a word
Context: ...further development of the Odra. Visit the the [Odra Roadmap](https://github.com/orgs/...
Near line 15: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...elease new versions approximately every 1-2 months or as needed. ## New Features ...
Near line 21: Make sure that ‘the one of’ is correct and that ‘one’ is a pronoun. Possibly, the ‘the’ is unnecessary or ‘of’ is better expressed with a preposition such as ‘about’ or ‘in’.
Context: ...n the feature is ready, we assign it to the one of the future release.
Near line 21: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ..., we assign it to the one of the future release.
Additional comments not posted (3)
ROADMAP.md (1)
5-5
: Updated URL for the Odra Roadmap is correct.examples/resources/casper_contract_schemas/signature_verifier_schema.json (1)
8-8
: Version update to "1.0.0" is correct and aligns with the PR objectives.examples/resources/casper_contract_schemas/dog_contract2_schema.json (1)
8-8
: Version update to "1.0.0" is correct and aligns with the PR objectives.
@@ -19,5 +18,4 @@ We release new versions approximately every 1-2 months or as needed. | |||
|
|||
Everyone is encouraged to propose a new Odra feature or enhancement. | |||
New proposals need to be discussed and approved by the core team. | |||
First, they are assigned the special Future Release, where they can mature. | |||
When the feature is ready, we assign it to the one of the future release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the grammatical error.
- we assign it to the one of the future release.
+ we assign it to one of the future releases.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
When the feature is ready, we assign it to the one of the future release. | |
When the feature is ready, we assign it to one of the future releases. |
@@ -2,8 +2,7 @@ | |||
|
|||
This document covers the way we plan further development of the Odra. | |||
|
|||
If you're looking for the Odra Roadmap, | |||
visit <https://github.com/odradev/odra/milestones>. | |||
Visit the the [Odra Roadmap](https://github.com/orgs/odradev/projects/3) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the repeated word "the".
- Visit the the [Odra Roadmap](https://github.com/orgs/odradev/projects/3)
+ Visit the [Odra Roadmap](https://github.com/orgs/odradev/projects/3)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Visit the the [Odra Roadmap](https://github.com/orgs/odradev/projects/3) for details. | |
Visit the [Odra Roadmap](https://github.com/orgs/odradev/projects/3) for details. |
Summary by CodeRabbit
New Features
Documentation
ROADMAP.md
to point to the new URL.Chores
categories
field from theCargo.toml
file forodra-casper-test-vm
to streamline project categorization.