-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing odra::prelude path in generated code #436
Conversation
WalkthroughThe recent updates in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- odra-macros/src/ast/contract_ref_item.rs (12 hunks)
- odra-macros/src/ast/entrypoints_item.rs (7 hunks)
- odra-macros/src/ast/external_contract_item.rs (2 hunks)
- odra-macros/src/ast/host_ref_item.rs (12 hunks)
- odra-macros/src/ast/ref_utils.rs (2 hunks)
- odra-macros/src/ast/test_parts.rs (7 hunks)
Files not reviewed due to errors (3)
- odra-macros/src/ast/external_contract_item.rs (no review received)
- odra-macros/src/ast/entrypoints_item.rs (no review received)
- odra-macros/src/ast/test_parts.rs (no review received)
Files skipped from review due to trivial changes (1)
- odra-macros/src/ast/contract_ref_item.rs
Additional comments not posted (14)
odra-macros/src/ast/ref_utils.rs (2)
73-74
: Useodra::prelude::string::String::from
for string creation.The change to use
odra::prelude::string::String::from
ensures consistency in string creation across the codebase.
83-85
: Useodra::prelude::string::String::from
for string creation.The change to use
odra::prelude::string::String::from
ensures consistency in string creation across the codebase.odra-macros/src/ast/host_ref_item.rs (12)
427-427
: Update to useodra::prelude::string::String::from("init")
looks good.
448-448
: Update to useodra::prelude::string::String::from("total_supply")
looks good.
467-467
: Update to useodra::prelude::string::String::from("pay_to_mint")
looks good.
492-492
: Update to useodra::prelude::string::String::from("approve")
looks good.
514-514
: Update to useodra::prelude::string::String::from("airdrop")
looks good.
598-598
: Update to useodra::prelude::string::String::from("total_supply")
looks good.
618-618
: Update to useodra::prelude::string::String::from("pay_to_mint")
looks good.
719-719
: Update to useodra::prelude::string::String::from("total_supply")
looks good.
739-739
: Update to useodra::prelude::string::String::from("get_owner")
looks good.
760-760
: Update to useodra::prelude::string::String::from("set_owner")
looks good.
782-782
: Update to useodra::prelude::string::String::from("name")
looks good.
803-803
: Update to useodra::prelude::string::String::from("symbol")
looks good.
Summary by CodeRabbit
Refactor
odra::prelude::string::String::from
for better consistency and code readability.Bug Fixes
These changes enhance code maintainability and readability without impacting end-user functionality.