Create element metadata security #8559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
| effectiveTime, | ||
| methodName); | ||
| genericHandler.validateEntityAndAnchorForRead(serverUserId, | ||
| entityProxy.getGUID(), |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
| @@ -61,7 +61,8 @@ | |||
| * | |||
| * @return subclass of InstancePropertyValue | |||
| */ | |||
| public InstancePropertyValue cloneFromSubclass() { | |||
| public InstancePropertyValue cloneFromSubclass() | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @param instance instance details | ||
| * @return flag indicating whether the reference copy should be saved | ||
| */ | ||
| public boolean validateEntityReferenceCopySave(EntityDetail instance) | ||
| public boolean validateEntityReferenceCopySave(String userId, EntityDetail instance) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @param instance instance details | ||
| * @return flag indicating whether the reference copy should be saved | ||
| */ | ||
| public boolean validateRelationshipReferenceCopySave(Relationship instance) | ||
| public boolean validateRelationshipReferenceCopySave(String userId, Relationship instance) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the generic handlers and metadata security module to create a data-oriented security authorization capability centered around all metadata element. It replaces the three specialist interfaces for Asset, Glossary and Connection.
At this time the new framework is in place but not activated in the default servers.
Testing
The updates of the generic handlers to call the new framework also includes some performance enhancements. The testing has focus on regresion testing to ensure nothing has broken rather than exercising the new function
Release Notes & Documentation
The new framework needs to be added to https://egeria-project.org/features/metadata-security/overview/
Additional notes